search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

Adds methods to update SSL Options to WebClient #2661

Closed frankgh closed 4 weeks ago

frankgh commented 1 month ago

This commit adds the ability to update the SSLOptions on the WebClient, similar to the methods in io.vertx.core.http.HttpClient. Internally, we delegate the calls to the underlying client.

Motivation:

Explain here the context, and why you're making that change, what is the problem you're trying to solve.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

vietj commented 4 weeks ago

@frankgh can you rebase on latest master of vertx-web ?

frankgh commented 4 weeks ago

@frankgh can you rebase on latest master of vertx-web ?

I was able to compile locally, I've fixed a few things, and CI should be green now.

vietj commented 4 weeks ago

@frankgh thank you