Prevent duplicate invocation of error handler

vert-x3 / vertx-web

HTTP web applications for Vert.x

Apache License 2.0

1.11k stars 535 forks source link

Prevent duplicate invocation of error handler #2667

Closed ljpengelen closed 4 weeks ago

ljpengelen commented 4 weeks ago

Motivation:

Backport of https://github.com/vert-x3/vertx-web/pull/2662 and https://github.com/vert-x3/vertx-web/pull/2666.

ljpengelen commented 4 weeks ago

As far as I can see, the test failure is not caused by the changes in this PR. There seems to be something wrong with CSRFHandlerTest#simultaneousGetAndPostDoesNotOverrideTokenInSession. On my machine, it fails when I run it in isolation, but succeeds when its executed together with the other tests in the class CSRFHandlerTest.

vietj commented 4 weeks ago

can you rebase on master ? thanks for cherry picking also the change I did after.

vietj commented 4 weeks ago

thanks @ljpengelen