search

vert-x3 / vertx-web

HTTP web applications for Vert.x
Apache License 2.0
1.11k stars 535 forks source link

fix(#2283): Prevent MultipartFormUpload PostRequestEncoder including transfer-encoding:chunked #2668

Open zekronium opened 4 weeks ago

zekronium commented 4 weeks ago

Motivation:

Currently, MultipartFormUpload uses PostRequestEncoder which includes transfer-encoding headers which are illegal in HTTP2 and HTTP3 as per the RFC.

Currently it is a simple fix, maybe this should be improved from the netty side itself to prevent needing to rewrite/polyfill the entire PostRequestEncoder just for such a small thing.

Fixes #2283

Side note: When testing, I noticed that the MultipartFormUpload does not report any exceptions. If theres a failure in any of the handlers, the context is unaware. Is that intentional?