search

vert-x3 / vertx-zookeeper

Zookeeper based cluster manager implementation
Other
73 stars 67 forks source link

vertx-zookeeper 4.0.0Beta/CR is not released #107

Closed blindpirate closed 3 years ago

blindpirate commented 4 years ago

image

Is this intentional?

vietj commented 4 years ago

it has not been yet released because it is not finished.

@stream-iori what is the status ?

blindpirate commented 3 years ago

@vietj I DMed @stream-iori , he said everything has been done for 4.0.0 and master is releaseable.

cc @tsegismont Can we release a 4.0.0 RC ?

vietj commented 3 years ago

@blindpirate I missed that, I think first we should add continuous integration for this then

vietj commented 3 years ago

I created a PR with the GitHub action CI : https://github.com/vert-x3/vertx-zookeeper/pull/108

vietj commented 3 years ago

there is currently one failure in the tests

https://github.com/vert-x3/vertx-zookeeper/runs/1466777157?check_suite_focus=true

does it ring a bell to anyone @stream-iori @tsegismont ?

anybody can chime in and help :-)

blindpirate commented 3 years ago

@vietj I fixed that issue by https://github.com/vert-x3/vertx-zookeeper/pull/109

However, there seems still an issue in ZKClusteredHATest.after(), which is quite flaky on my local computer. Maybe we can merge #108 first to help catch all future failures?

tsegismont commented 3 years ago

@vietj the failing test is the test I added recently related to clustered consumer unregistration.

It seems #109 would fix it indeed (thanks @blindpirate )