search

vert-x3 / vertx-zookeeper

Zookeeper based cluster manager implementation
Other
72 stars 67 forks source link

Fix SubsMapHelper not listening ChildEvents #109

Closed blindpirate closed 3 years ago

blindpirate commented 3 years ago

Context

Discussions in https://github.com/vert-x3/vertx-zookeeper/issues/107

Previously, SubsMapHelper was not registered as TreeCache listener, which results in missing registrationsUpdated events. Also, the address it parsed from event data was also incorrect. This PR fixes both issues.

tsegismont commented 3 years ago

@stream-iori can you please review ?

tsegismont commented 3 years ago

@blindpirate thanks for the fix

@stream-iori @vietj I built the repo on my laptop and the test suite passed.

blindpirate commented 3 years ago

The current failure https://github.com/vert-x3/vertx-zookeeper/runs/1485536207 is what I observed locally: the failures are flaky. @stream-iori it would be great if you can give us some hints.

stream-iori commented 3 years ago

Does failures is same in multi times test?

在 2020年12月2日，下午6:48，Bo Zhang notifications@github.com 写道：

 The current failure https://github.com/vert-x3/vertx-zookeeper/runs/1485536207 is what I observed locally: the failures are flaky. @stream-iori it would be great if you can give us some hints.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

blindpirate commented 3 years ago

@stream-iori No, they're flaky, so the failed test is not fixed.