search

vert-x3 / vertx-zookeeper

Zookeeper based cluster manager implementation
Other
72 stars 67 forks source link

#124 Update curator #131

Closed vmorsiani closed 1 year ago

vmorsiani commented 1 year ago

Motivation:

curator-framework version is quite outdated and have vulnerabilities as shown in ticket #124 I therefore updated both version of curator-framework as well as zookeeper.

Because curator-test migrated to junit5, I had to bump versio to junit to 5 as well and included a dependency on junit-vintage to ensure tests were still working

Conformance:

tsegismont commented 1 year ago

Can you take a look at the test failures?

vmorsiani commented 1 year ago

Looking at the CI history it looks like this test is failing for some reason on master as well. Locally it all works fine for me.

I'll try to have a look at the test a bit later on and see if I can reproduce the issue.

tsegismont commented 1 year ago

Thank you VincentMessage ID: <vert-x3/vertx-zookeeper/pull/131/c1420990245@ github.com>