search

vert-x3 / vertx-zookeeper

Zookeeper based cluster manager implementation
Other
73 stars 67 forks source link

Round robin with EventBus #17

Closed teivah closed 8 years ago

teivah commented 8 years ago

Hello,

Thanks for this implementation, this is really useful.

I just wanted to raise the fact that the round robin publication from the EventBus does not seem to be managed. Indeed, the ZKAsyncMultiMap.get() method create a new ChoosableSet each time. It means the ChoosableSet.choose() method returns always the same element.

It might be great to implement a round-robin strategy (by caching the ChoosableSet for instance to make sure a new instance is not created each time?).

Thanks

stream-iori commented 8 years ago

Looks like #10 I will do my best to make vertx-zookeeper work fine before vert.x 3.3.0 release

teivah commented 8 years ago

Oh sorry you're right, this is the same issue. Thanks for the support.

teivah commented 8 years ago

Duplicate of #10