search

vert-x3 / vertx-zookeeper

Zookeeper based cluster manager implementation
Other
73 stars 67 forks source link

replace zk config format by json. #29

Closed stream-iori closed 8 years ago

stream-iori commented 8 years ago

As vertx use json format for config file, so i think we can replace properties with json

Signed-off-by: stream stream1984@gmail.com

cescoffier commented 8 years ago

Looks good to me.

However, if I understand correctly, there is an API change (breaking change). Can you confirm ?

stream-iori commented 8 years ago

Yes, there is parameter change from properties to jsonObject, but vertx-zookeeper never release and this change can only effect zookeeper config file, so i think this could be acceptable. :)

cescoffier commented 8 years ago

Ok

I realized that this cluster manager has never been managed, so it's not an issue. Once the first release is done, breaking changes need to be collected in the Vert.x wiki.