search

vert-x3 / vertx-zookeeper

Zookeeper based cluster manager implementation
Other
73 stars 67 forks source link

Fault tolerance for event bus subscription #45

Closed tsegismont closed 7 years ago

tsegismont commented 7 years ago

See eclipse/vert.x#1848

I couldn't add the FaultToleranceTest since tests in this CM use a mock ZK server

tsegismont commented 7 years ago

Do not merge before eclipse/vert.x#1848

tsegismont commented 7 years ago

@stream1984 can you have a look please? Thanks!

stream-iori commented 7 years ago

@tsegismont LGTM, I will merge it after vert.x#1848 be merged, and also try to add some test for it.

tsegismont commented 7 years ago

Thank you

2017-03-03 2:57 GMT+01:00 Stream notifications@github.com:

@tsegismont https://github.com/tsegismont LGTM, I will merge it after vert.x#1848 https://github.com/eclipse/vert.x/pull/1848 be merged, and also try to add some test for it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-zookeeper/pull/45#issuecomment-283842470, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbltmuro0pNnnZtZWO2JlyveR4SVB4Eks5rh3NzgaJpZM4MPilf .

tsegismont commented 7 years ago

@stream1984 the upstream PR has been merged