vert-x3 / vertx-zookeeper

Zookeeper based cluster manager implementation
Other
73 stars 67 forks source link

Expose AsyncMap keys, values and entries #62

Closed tsegismont closed 7 years ago

tsegismont commented 7 years ago

See https://github.com/eclipse/vert.x/issues/2020

tsegismont commented 7 years ago

@stream1984 can you please review? But please do not merge yet since @vietj must approve the PR in core first. Thanks

stream-iori commented 7 years ago

Got it.

tsegismont commented 7 years ago

@stream1984 a few things to note:

  1. this PR changes the ways keys are stored otherwise we can't recreate the original object.

As a consequence:

  1. the Base64 url decoder is used on purpose because it uses - and _ instead of + and / (Zookeeper is confused if a key contains a slash)