P2pool hardfork to 35 protocol

kr1z1s commented 3 years ago

correct conversion all users addresses (bech32 and other)
remove tx from charechain
remove tx forwarding
fast parsing transactions from vertcoind
low memory consumption
low doa and orphans
all pool shares vardiff (stratum and pool shares)
worker names support (use "." or "_")
overall stability
and more fixes

metalicjames commented 3 years ago

Could you rebase this onto master and remove the donation script?

metalicjames commented 3 years ago

When running this I get:

2021-02-18 20:57:52.622324 Determining payout address...
2021-02-18 20:57:52.622365     Getting payout address from bitcoind...
2021-02-18 20:57:52.623867 > Error getting payout address from bitcoind:
2021-02-18 20:57:52.623902 > Traceback (most recent call last):
2021-02-18 20:57:52.623924 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
2021-02-18 20:57:52.623947 >     current.result = callback(current.result, *args, **kw)
2021-02-18 20:57:52.623968 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1101, in gotResult
2021-02-18 20:57:52.623990 >     _inlineCallbacks(r, g, deferred)
2021-02-18 20:57:52.624011 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1043, in _inlineCallbacks
2021-02-18 20:57:52.624033 >     result = result.throwExceptionIntoGenerator(g)
2021-02-18 20:57:52.624054 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator
2021-02-18 20:57:52.624076 >     return g.throw(self.type, self.value, self.tb)
2021-02-18 20:57:52.624096 > --- <exception caught here> ---
2021-02-18 20:57:52.624116 >   File "/home/james/workspace/p2pool-vtc/p2pool/util/deferral.py", line 41, in f
2021-02-18 20:57:52.624138 >     result = yield func(*args, **kwargs)
2021-02-18 20:57:52.624159 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1043, in _inlineCallbacks
2021-02-18 20:57:52.624202 >     result = result.throwExceptionIntoGenerator(g)
2021-02-18 20:57:52.624237 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator
2021-02-18 20:57:52.624265 >     return g.throw(self.type, self.value, self.tb)
2021-02-18 20:57:52.624287 >   File "/home/james/workspace/p2pool-vtc/p2pool/util/jsonrpc.py", line 133, in _http_do
2021-02-18 20:57:52.624313 >     raise Error_for_code(resp['error']['code'])(resp['error']['message'], resp['error'].get('data', None))
2021-02-18 20:57:52.624336 > p2pool.util.jsonrpc.NarrowError: -32601 Method not found

kr1z1s commented 3 years ago

Could you rebase this onto master and remove the donation script?

I'll clean it up, okay.

kr1z1s commented 3 years ago

When running this I get:

2021-02-18 20:57:52.622324 Determining payout address...
2021-02-18 20:57:52.622365     Getting payout address from bitcoind...
2021-02-18 20:57:52.623867 > Error getting payout address from bitcoind:
2021-02-18 20:57:52.623902 > Traceback (most recent call last):
2021-02-18 20:57:52.623924 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
2021-02-18 20:57:52.623947 >     current.result = callback(current.result, *args, **kw)
2021-02-18 20:57:52.623968 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1101, in gotResult
2021-02-18 20:57:52.623990 >     _inlineCallbacks(r, g, deferred)
2021-02-18 20:57:52.624011 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1043, in _inlineCallbacks
2021-02-18 20:57:52.624033 >     result = result.throwExceptionIntoGenerator(g)
2021-02-18 20:57:52.624054 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator
2021-02-18 20:57:52.624076 >     return g.throw(self.type, self.value, self.tb)
2021-02-18 20:57:52.624096 > --- <exception caught here> ---
2021-02-18 20:57:52.624116 >   File "/home/james/workspace/p2pool-vtc/p2pool/util/deferral.py", line 41, in f
2021-02-18 20:57:52.624138 >     result = yield func(*args, **kwargs)
2021-02-18 20:57:52.624159 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1043, in _inlineCallbacks
2021-02-18 20:57:52.624202 >     result = result.throwExceptionIntoGenerator(g)
2021-02-18 20:57:52.624237 >   File "/home/james/.local/lib/python2.7/site-packages/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator
2021-02-18 20:57:52.624265 >     return g.throw(self.type, self.value, self.tb)
2021-02-18 20:57:52.624287 >   File "/home/james/workspace/p2pool-vtc/p2pool/util/jsonrpc.py", line 133, in _http_do
2021-02-18 20:57:52.624313 >     raise Error_for_code(resp['error']['code'])(resp['error']['message'], resp['error'].get('data', None))
2021-02-18 20:57:52.624336 > p2pool.util.jsonrpc.NarrowError: -32601 Method not found

Oh...

getaccountaddress - is deprecated

metalicjames commented 3 years ago

The current master branch has fixes for the deprecated RPCs. They must've been overwritten by this PR.

kr1z1s commented 3 years ago

I made the changes. Why the conflict?

metalicjames commented 3 years ago

I made the changes. Why the conflict?

You'll need to rebase onto the current master branch. Use git rebase master once your master branch is in line with the current one.

kr1z1s commented 3 years ago

I made the changes. Why the conflict?

You'll need to rebase onto the current master branch. Use git rebase master once your master branch is in line with the current one.

Complete

vertcoin-project / p2pool-vtc

P2pool hardfork to 35 protocol #50