vertelab / odoo-af

2 stars 5 forks source link

AFC-2145 Interpreter summary in the log. #571

Closed Radhika435 closed 3 years ago

Radhika435 commented 3 years ago

Userstory: As a user, I wanted to see the text on the chatter logg to be more relevant in context to the Interpreter booking. Step 1: Please check the picture below which shows the technical text and task created. image

Step 2: Instead of the technical text we wanted to see the text like this, when the interpreter booking is done(check the Interpreter_booking_status = order received) then show this message below.

image

Step 3: When the interpreter booking is confirmed(check the Interpreter_booking_status = booked) image

And also instead of "task created" we can show that Interpreter task has done.

Module name: (added by Nils or Fredrik) https://github.com/vertelab/odoo-outplacement/tree/Dev-12.0-Fenix-Sprint-02/outplacement_order_interpreter

Development Branch name: Dev-12.0-AFC-2145_improved_booking_confirmation

Target Branch name: https://github.com/vertelab/odoo-outplacement/tree/Dev-12.0-Fenix-Sprint-02/

Description to the manifest: This version improves the booking message for interpreters.

Estimate: (@developers: Add your times here, not in comments please) Estimated Hours: Estimated Date: Actual Hours: 2 hours and 50 Mins(Discussion, Development, Created PR, Prepared videos etc)

Radhika435 commented 3 years ago

FYI @FredrikArvas

rupareliyahemangi145 commented 3 years ago

Hello @FredrikArvas I think if we create new branch Dev-12.0-AFC-2145_improved_booking_confirmation that will merge in Dev-12.0-Fenix-Sprint-02 branch. It will create conflict.

As we have already one branch 12.0-DAFA-AFC-2125-interpreter-booking-show-made-bookings that will merge in Dev-12.0-Fenix-Sprint-02 and this branch contain changes of same module outplacement_order_interpreter.

My suggestion to do changes in 12.0-DAFA-AFC-2125-interpreter-booking-show-made-bookings.

Please let me know your suggestion.

FredrikArvas commented 3 years ago

I think this is good. And close the PR that should not be used.

You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/vertelab/odoo-af/issues/571#issuecomment-842972788, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACH53EQMCS7PDDWOI4PJDDLTOIRCRANCNFSM44YIKRPA .

--


Fredrik Arvas, @.*** Send PGP-encrypted messages to me: https://flowcrypt.com/me/fredrikarvasse ///handduken.arbetade.rymd (exakt adress med what3words) Lillebovägen 13, 132 36 Saltsjö-Boo, Sweden Mobil: +46708145595 Webb https://08arvasi.se/ | Blogg http://fredrik.arvas.se/ | LinkedIn https://www.linkedin.com/in/fredrikarvas | We support Ecpat mot dokumenterade övergrepp https://www.ecpat.se/tanerbilderna


rupareliyahemangi145 commented 3 years ago

Ok @FredrikArvas Thanks.

rupareliyahemangi145 commented 3 years ago

Hello @Radhika435 Can you please send me screenshots of 'Interpreter Types'. You are using 2 interpreter types, right?

Please open form view of both and send me screenshots of them. So I can reproduce and test with same.

fredrikarvas-vertel commented 3 years ago

@Radhika435 I think it is easier to do this on Nils dev-server. Since Hemangi does not have access to Tolkportalen.

rupareliyahemangi145 commented 3 years ago

@Radhika435 and @FredrikArvas In Step 2, We don't need to show address if interpreter type is not 'platstolk'? I mean address should be visible only on 'platstolk' interpreter type?

fredrikarvas-vertel commented 3 years ago

yes. /Fredrik

rupareliyahemangi145 commented 3 years ago

Ok Thanks @FredrikArvas

rupareliyahemangi145 commented 3 years ago

Hello @Radhika435 and @FredrikArvas ,

I've worked on this issue and here is commit for that: https://github.com/vertelab/odoo-outplacement/commit/6d3221b39cba1374a634355dd70ec9599f866ad1 https://github.com/vertelab/odoo-outplacement/commit/b4e2ada16188c99669e125db494789c9e15903a4 https://github.com/vertelab/odoo-outplacement/commit/5dbfc292bfd182c2f34edaea21d6260aad605fbb This commit is for step-1 and step-3.

Log of step-2 is comes from task_interpreter_ipf_client module so created this PR https://github.com/vertelab/odoo-project/pull/27 for step-2.

Here is video for result: https://www.loom.com/share/99706fbc437d464fb63214ab8c52f3df

Please check it and let me know if anything.

Thanks.

Regards, Hemangi.