AFC-2468-hide social security number and AFC-2546

[fredrikarvas-vertel]

Userstory: As a normal user, I do not want to see my collegues social security number.

Show only SSN No for "DAFA Admin Read". 

Show only Legacy ID for ServiceDesk1 or above.

Module name: (added by Nils or Fredrik) Revert changes in: https://github.com/vertelab/odoo-outplacement/tree/Dev-12.0-Fenix-Sprint-02/outplacement Add changes in: https://github.com/vertelab/odoo-hr/blob/Dev-12.0-Fenix-Sprint-02/hr_employee_views_dafa/views/hr_views.xml

Development Branch name: Dev-12.0-AFC-2546_hide_ssn_in_hr_employee

Target Branch name: https://github.com/vertelab/odoo-outplacement/tree/Dev-12.0-Fenix-Sprint-02/

Description to the manifest: Hides the field ssn for non-employee-admins.

Estimate: (@developers: Add your times here, not in comments please) Estimated Hours: Estimated Date: Actual Hours: 30 mins 1 Hour - Removed groups from outplacement and added on employee view for SSN and Legacy. 50 mins - Tried to find way to hide only SSN log from chatter based on group. 30 mins - Prevented tracking on SSN from chatter.

[rupareliyahemangi145]

Ok @FredrikArvas I will check this issue.

[rupareliyahemangi145]

Hello @FredrikArvas

I've created PR https://github.com/vertelab/odoo-outplacement/pull/243 for this issue.

Please check it and let me know if anything.

Thanks.

Regards, Hemangi.

[fredrikarvas-vertel]

Hi @rupareliyahemangi145

I am sorry, the requirements in this issue leads to the wrong module. 1 We want to show the Social security number in the outplacement-module. (Please revert the changes) 2 We want to hide the SSN in the hr_employee-module.

[rupareliyahemangi145]

Ok Sure @FredrikArvas

[rupareliyahemangi145]

Hello @FredrikArvas

Inside Employee, You want to hide for all users or want to show only for DAFA Admin Read user?

[fredrikarvas-vertel]

I want to show it for Show only SSN No for "DAFA Admin Read", "DAFA Employee Write", and "ServiceDesk1 (https://github.com/vertelab/odoo-base/blob/b489f127540767f759e18037b541e5958a720539/base_user_groups_dafa/security/security.xml#L129) or ServiceDesk2 and ServiceDesk3 (who inherits ServiceDesk1)" Show only Legacy ID for ServiceDesk1 or above.

[rupareliyahemangi145]

Hello @FredrikArvas

I've created PRs for this issue. https://github.com/vertelab/odoo-outplacement/pull/258 https://github.com/vertelab/odoo-hr/pull/73

Please check it and let me know if anything.

Thanks.

Regards, Hemangi.

[Anushalewis]

Test results : Test results AFC-2468.docx

[Anushalewis]

@rupareliyahemangi145 : please have a look at the test results.

[rupareliyahemangi145]

Ok @Anushalewis

[rupareliyahemangi145]

Hello @Anushalewis

Created PR https://github.com/vertelab/odoo-hr/pull/77 to fix issue. Please check it and let me know if anything.

Thanks.

Regards, Hemangi.

[Anushalewis]

@rupareliyahemangi145 : new test results, its working on display and hide on legacy id but ssn wast visible on employee. please find attached the screen shots Test results AFC-2468 new.docx

[rupareliyahemangi145]

Ok @Anushalewis I will check it

[rupareliyahemangi145]

Hello @Anushalewis

Can we check this issue on call?

[rupareliyahemangi145]

Hello @Anushalewis ,

Please upgrade hr_employee_views_dafa module on both servers and let me know if still issue exits or need any help.

Thanks. Regards,Hemangi.

[Anushalewis]

Hi @rupareliyahemangi145 : please have a look at the attached document for screen shots after the upgrade on both servers. 2468 .docx

Thanks, Anusha Lewis

[rupareliyahemangi145]

Let's connect again.

[Anushalewis]

Hi @rupareliyahemangi145 , please have a look at the screen shots the ssn number is hidden from general information on employee page , but visible on chatter messages. 2468 chatter ssn.docx

[rupareliyahemangi145]

Ok @Anushalewis I will try to find way to hide from chatter.

[rupareliyahemangi145]

Hello @FredrikArvas and @Anushalewis

I tried to find way to hide from chatter based on group but didn't find any solution. We have to hide whole chatter area based on user access group. Is it ok?

[fredrikarvas-vertel]

No @rupareliyahemangi145, we can not hide the whole chatter-area. But we can stop the monitoring of change of SSN (not a good solution but maybe the best now).

[rupareliyahemangi145]

Ok @FredrikArvas I have another solution. We can add new One2many field to store SSN change log and can stop monitoring from chatter

[fredrikarvas-vertel]

I think the requriements to log changes are unclear. At this point, i think it is best to stop logging change of SSN.

[fredrikarvas-vertel]

We have other logging functions that will be implemented in the future. I think we can rely on them then.

[rupareliyahemangi145]

Ok @FredrikArvas I will stop logging of SSN from chatter now.

[fredrikarvas-vertel]

Thanks

[rupareliyahemangi145]

Hello @FredrikArvas and @Anushalewis

I've create PR https://github.com/vertelab/odoo-auth/pull/25 to prevent tracking of SSN from chatter. Please check it when you can and let me know if anything.

Thanks.

Regards, Hemangi.