vertexclique / tokamak

Fusion Reactor for Rust - Atom Rust IDE
https://vertexclique.github.io/tokamak/
MIT License
399 stars 13 forks source link

Success window for dependency tool keeps appearing #28

Closed davisein closed 8 years ago

davisein commented 8 years ago

I am getting this notification every time I start atom.

I can see why this is useful for development of the plugin or if you were struggling to get it working (the first times I was missing racer), but after that it gets annoying specially if you use atom for more than Rust.

screen shot 2016-04-14 at 15 55 08

Can we remove it or make it more intelligent?

vertexclique commented 8 years ago

If you are mentioning toolchain detection code then I will refactor it. This will show once after dependency installation complete. @davisein

Sorry I am looking for it now.

vertexclique commented 8 years ago

Actually it shows up only if you have missing package and then it tries to install thereafter shows this up.

davisein commented 8 years ago

@vertexclique It seems to show once for every Window open. I have tried closing Atom and reopening it and it was shown again. Can I help somehow to diagnose?

I have tried closing atom and reopening again 3 times. Each time it showed the same message even without the Detect binaries on startup being enabled. I'm using 0.2.7 version of Tokomak on Atom 1.7.1

Let me know how can I be of help and thanks for the good work.

vertexclique commented 8 years ago

@davisein Hmm interesting that Detect binaries on startup doesn't help with that. If you have a fix for that feel free to open a PR.

vertexclique commented 8 years ago

By introducing general_warnings feature in tokamak configuration file this problem solved. For more info please visit: https://github.com/vertexclique/tokamak#токамак-project-configuration Thanks!