search

vertexclique / tokamak

Fusion Reactor for Rust - Atom Rust IDE
https://vertexclique.github.io/tokamak/
MIT License
399 stars 13 forks source link

RLS install failing, existing RLS not found #87

Open leavengood opened 6 years ago

leavengood commented 6 years ago

So it seems the way RLS is supposed to be installed has changed recently. In Tokamak 0.4.1 I was getting console errors when trying to install the RLS:

Uncaught (in promise) Error: Command failed: /Users/leavengood/.cargo/bin/rustup component add rls --toolchain nightly
error: toolchain 'nightly-x86_64-apple-darwin' does not contain component 'rls' for target 'x86_64-apple-darwin'

I then followed the instructions on https://github.com/rust-lang-nursery/rls to manually install RLS using rustup, but not on nightly, on the stable channel. Therefore since Tokamak is trying to run the RLS with the nightly toolchain, it could not run:

https://github.com/vertexclique/tokamak/blob/master/lib/rls.js#L153

I got the RLS working in Tokamak by commenting out the contents of checkRLS() and just returning a resolved Promise, and changing the above nightly cargo parameter to stable.

I am not sure of the proper solution, otherwise I might consider a PR.

Otherwise I found hacking on Tokamak pretty easy!

leavengood commented 6 years ago

This is with these versions: Atom 1.25.0, Rust 1.24.1, rustup 1.11.0, Cargo 0.25.0 on Mac OS X 10.10.5.