allow non HTTPUnauthorized errors to bubble up

vertexcover-io / falcon-auth

A falcon middleware + authentication backends that adds authentication layer to you app/api service.

MIT License

103 stars 31 forks source link

allow non HTTPUnauthorized errors to bubble up #5

Closed timc13 closed 7 years ago

timc13 commented 7 years ago

MultiAuthBackend was swallowing all exceptions and raising HTTPUnauthorized. This is inconsistent with the other backends which correctly bubbles up unexpected exceptions.

coveralls commented 7 years ago

Coverage increased (+1.6%) to 87.5% when pulling f2c0ceb150f3d2d61b44379dd43d35494059ee8c on timc13:patch-multiauthbackend into 81063802243aa42d2c8d4cb77e7bb88435511f69 on loanzen:master.

timc13 commented 7 years ago

It's just a dummy backend to test that when exception is raised, it is thrown properly and not swallowed. I've modified it a bit to hopefully make it more clear.

coveralls commented 7 years ago

Coverage increased (+1.6%) to 87.5% when pulling 1de7cc22e4166d20efb53bbd602f82ad28fa200c on timc13:patch-multiauthbackend into 81063802243aa42d2c8d4cb77e7bb88435511f69 on loanzen:master.

timc13 commented 7 years ago

@kgritesh does that make sense? I would love to use this lib - but need proper error handling...

kgritesh commented 7 years ago

@timc13 Sorry for the delay and thanks a lot for the pull request. Appreciate it.

timc13 commented 7 years ago

thanks! do you think you can publish a new version to pypi ?

kgritesh commented 7 years ago

@timc13 sorry forgot. Done now.