codecov[bot]
commented
4 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.27%. Comparing base (
91e49a9) to head (9e385b3). Report is 11 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #3857 +/- ## ========================================== - Coverage 96.33% 96.27% -0.07% ========================================== Files 243 243 Lines 54033 54032 -1 ========================================== - Hits 52052 52018 -34 - Misses 1981 2014 +33 ``` | [Flag](https://app.codecov.io/gh/vertexproject/synapse/pull/3857/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/vertexproject/synapse/pull/3857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `96.27% <100.00%> (+0.02%)` | :arrow_up: | | [linux_replay](https://app.codecov.io/gh/vertexproject/synapse/pull/3857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
My guess is that this was intended to somehow handle a
concurrent.Futuremaking it here in this invalid state asresult()will actually make that wait rather than throwing an InvalidStateError. This should be an asyncio task though, and I still don't see any way that the done callback could fire and not be in the done state here.