vertexproject / synapse

Synapse Central Intelligence System
Apache License 2.0
349 stars 72 forks source link

Fix issue with automatic aha provisioning URL & bind precedence (SYN-7869) #3866

Closed vEpiphyte closed 2 weeks ago

vEpiphyte commented 3 weeks ago

If the dns label is not available during service startup listening fails.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.29%. Comparing base (29e0cc0) to head (63cdb1e). Report is 4 commits behind head on master.

Files Patch % Lines
synapse/lib/aha.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3866 +/- ## ========================================== - Coverage 96.37% 96.29% -0.08% ========================================== Files 244 244 Lines 54469 54469 ========================================== - Hits 52494 52453 -41 - Misses 1975 2016 +41 ``` | [Flag](https://app.codecov.io/gh/vertexproject/synapse/pull/3866/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/vertexproject/synapse/pull/3866/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `96.29% <0.00%> (-0.01%)` | :arrow_down: | | [linux_replay](https://app.codecov.io/gh/vertexproject/synapse/pull/3866/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.