search

vertexproject / synapse

Synapse Central Intelligence System
Apache License 2.0
349 stars 72 forks source link

Improve error handling in $lib.stix.import.ingest (SYN-7837) #3867

Closed Cisphyx closed 2 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.30%. Comparing base (55743fe) to head (4561005). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3867 +/- ## ========================================== - Coverage 96.37% 96.30% -0.08% ========================================== Files 244 244 Lines 54470 54488 +18 ========================================== - Hits 52497 52476 -21 - Misses 1973 2012 +39 ``` | [Flag](https://app.codecov.io/gh/vertexproject/synapse/pull/3867/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/vertexproject/synapse/pull/3867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `96.30% <100.00%> (+<0.01%)` | :arrow_up: | | [linux_replay](https://app.codecov.io/gh/vertexproject/synapse/pull/3867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cisphyx commented 2 weeks ago

Approving, but is this something we should be using a JSON schema for?

Good point, yeah a validator would probably be good here.