Cisphyx
commented
2 weeks ago Should we remove the other defensive code to make it clear where this is being enforced ( and not do so twice? )
We can cut that out yeah, I wasn't sure if we wanted to leave those in since they're a little more user friendly error messages.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #3874 +/- ## ========================================== - Coverage 96.36% 96.28% -0.08% ========================================== Files 244 244 Lines 54699 54706 +7 ========================================== - Hits 52712 52675 -37 - Misses 1987 2031 +44 ``` | [Flag](https://app.codecov.io/gh/vertexproject/synapse/pull/3874/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/vertexproject/synapse/pull/3874/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `96.28% <100.00%> (-0.01%)` | :arrow_down: | | [linux_replay](https://app.codecov.io/gh/vertexproject/synapse/pull/3874/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vertexproject#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.