search

vertica / spark-connector

This component acts as a bridge between Spark and Vertica, allowing the user to either retrieve data from Vertica for processing in Spark, or store processed data from Spark into Vertica.
Apache License 2.0
20 stars 23 forks source link

Changed Vertica version comparisons to use relational operators #529

Closed ai-bq closed 1 year ago

ai-bq commented 1 year ago

Summary

The Spark Connector had Vertica versions compared through our own manually written functions. By extending the Ordered library we can use relational operators instead for cleaner code.

Description

Every instance of the manual functions were replaced by relational operators. Afterwards, the previous functions were removed.

Related Issue

Closes #518.

Additional Reviewers

@alexey-temnikov @alexr-bq

codecov[bot] commented 1 year ago

Codecov Report

Merging #529 (779d80b) into main (17547bc) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   87.58%   87.55%   -0.04%     
==========================================
  Files          44       44              
  Lines        2005     2000       -5     
  Branches      122      116       -6     
==========================================
- Hits         1756     1751       -5     
  Misses        249      249
Flag Coverage Δ
unittests 87.55% <100.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...scala/com/vertica/spark/util/version/Version.scala 100.00% <ø> (ø)
...vertica/spark/util/version/SparkVersionTools.scala 92.85% <100.00%> (ø)
...rtica/spark/util/version/VerticaVersionUtils.scala 98.03% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more