search

vertica / spark-connector

This component acts as a bridge between Spark and Vertica, allowing the user to either retrieve data from Vertica for processing in Spark, or store processed data from Spark into Vertica.
Apache License 2.0
20 stars 23 forks source link

Java 8 isBlank fix + JDK 8 addition to Weekly workflow #535

Closed ai-bq closed 1 year ago

ai-bq commented 1 year ago

Summary

Java 8 was failing compilation of the Connector due to an unsupported method "isBlank." Additionally, Java 8 compilation is never tested and should be added to GH Actions.

Description

Imported an Apache Commons StringUtil library to handle the isBlank method call. JDK 8 has yet to have been added to Weekly testing.

Related Issue

Closes #534 and #536.

Additional Reviewers

@alexey-temnikov @alexr-bq @jonathanl-bq @jeremyp-bq

codecov[bot] commented 1 year ago

Codecov Report

Merging #535 (2d95b9d) into main (fed5787) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files          44       44           
  Lines        2000     2000           
  Branches      116      114    -2     
=======================================
  Hits         1751     1751           
  Misses        249      249
Flag Coverage Δ
unittests 87.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...la/com/vertica/spark/util/schema/SchemaTools.scala 88.55% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

haidernaveed commented 4 months ago

Can we get the jar of this build ? I can see the latest release is of Dec 2022 and im having the isBlank() error in that @jeremyprime @ai-bq @alexey-temnikov @jonathanl-bq