search

vertica / vertica-kubernetes

Operator, container and Helm chart to deploy Vertica in Kubernetes
Apache License 2.0
44 stars 25 forks source link

Fixes Istio proxy sidecar initialization issue #702

Closed spilchen closed 8 months ago

spilchen commented 8 months ago

Starting in istio 1.17, the istio proxy is now injected as the first container. This breaks some assumptions in the operator code. It assumes that any sidecar is injected at the end and the first two containers are the nma and server. This changes fixes that by referencing containers by their names rather than index. I removed all of the helpers based on index and instead get them by name.

roypaulin commented 8 months ago

There is a test that fails with Error response from daemon. Zhuoyu also got that error.

spilchen commented 8 months ago

There is a test that fails with Error response from daemon. Zhuoyu also got that error.

Yes, seems like an issue with our docker account. We no longer have pull access to our private repository where we keep all the server images. I have a PR opened (#704) to use a different repository for the time being.