search

vertica / vertica-kubernetes

Operator, container and Helm chart to deploy Vertica in Kubernetes
Apache License 2.0
44 stars 25 forks source link

Create webhook for VerticaRestorePointQuery CR #709

Closed chinhtranvan closed 8 months ago

chinhtranvan commented 8 months ago

This PR creates a webhook for the new VerticaRestorePointQuery CR to catch the checks early. There is some webhook part that is added in https://github.com/vertica/vertica-kubernetes/pull/643."

spilchen commented 8 months ago

Can we remove omitempty from VerticaRestorePointsQueryStatus.RestorePoints? I think that will make it clear when we create the CR and no results are returned.

spilchen commented 8 months ago

Can we remove omitempty from VerticaRestorePointsQueryStatus.RestorePoints? I think that will make it clear when we create the CR and no results are returned.

Never mind, I noticed that it's on the server side.

chinhtranvan commented 8 months ago

Can we remove omitempty from VerticaRestorePointsQueryStatus.RestorePoints? I think that will make it clear when we create the CR and no results are returned.

Never mind, I noticed that it's on the server side.

yes, I already opened a PR on the server side, you can take a look it https://git.verticacorp.com/projects/VER/repos/server/pull-requests/20274/overview