search

vertica / vertica-nodejs

Official native node.js client for the Vertica Analytics Database.
https://www.vertica.com/
Apache License 2.0
12 stars 14 forks source link

Add glob to package.json for 1.1.2 #135

Closed DMickens closed 6 months ago

DMickens commented 6 months ago

Fix #133

glob has been added to the yarn dependencies using yarn package manager interface yarn add glob. vertica-nodejs 1.1.2 and v-pool 1.1.2 as it depends on vertica-nodejs version have been updated.

Yarn.lock is updated with glob dependencies, and reflects global configuration preference for npmjs.org over yarnpkg.com when available.

sitingren commented 6 months ago

@DMickens Do you think the CI failure is introduced by your updates?

DMickens commented 6 months ago

@DMickens Do you think the CI failure is introduced by your updates?

It looks like one of the dependencies for that version of glob is using ECMAScript 2019 features which isn't supported by all of our node versions. I'll update the version of glob. I believe 7.1.6 should be supported by everything we claim to support. I'll push the changes and check the CI tests again

DMickens commented 6 months ago

@DMickens Do you think the CI failure is introduced by your updates?

It looks like one of the dependencies for that version of glob is using ECMAScript 2019 features which isn't supported by all of our node versions. I'll update the version of glob. I believe 7.1.6 should be supported by everything we claim to support. I'll push the changes and check the CI tests again

@sitingren That was the issue. It is updated and fixed now