OAuth Authentication Support

vertica / vertica-nodejs

Official native node.js client for the Vertica Analytics Database.

https://www.vertica.com/

Apache License 2.0

12 stars 14 forks source link

OAuth Authentication Support #146

Closed sitingren closed 3 months ago

sitingren commented 3 months ago

OAuth 2.0 Support
Add CI test with Keycloak
Upgrade requested protocol version from 3.5 to 3.16, and fix test regressions
Enforce connection string's scheme to be vertica://, and fix test regressions

DMickens commented 3 months ago

Took a first pass. It looks like a great implementation plus a lot of good clean up. I left a few comments. I'll do another more thorough review when I have enough time to test it out locally

DMickens commented 3 months ago

I added one new request for a comment. It is not a blocking concern so I will approve now. This looks great, both the new feature implementation and all of the cleanup is very nice to have.