search

vertica / vertica-nodejs

Official native node.js client for the Vertica Analytics Database.
https://www.vertica.com/
Apache License 2.0
13 stars 14 forks source link

Resolve rowDescription issue caused by parsing based on future protocol #24

Closed DMickens closed 2 years ago

DMickens commented 2 years ago

There were issues with parsing rowDescription messages. We were trying to parse a field for the attribute number of the parent type for complex types. That doesn't apply here and shouldn't be parsed. In addition I added more information that was being parsed in the RowDescriptionMessage to the Field type.

williammatherjones commented 2 years ago

Do we have tests that will catch this if it breaks in the future? For example: if we bump the protocol version and don't make the parent change. I'm wondering if those tests are among the ones that are currently failing?

williammatherjones commented 2 years ago

This was superseded by Jonathan's PR#27. This PR will not be merged.