vertica / vertica-nodejs

Official native node.js client for the Vertica Analytics Database.

https://www.vertica.com/

Apache License 2.0

12 stars 14 forks source link

Support of Node engine v12 #86

Closed korowa closed 2 years ago

korowa commented 2 years ago

Rationale for this change

Currently minimal version of Node engine is 14, but some projects may require support of earlier engine versions. Suggestion is to decrease minimal required version of engine to 12.

What changes are included in this PR?

vertica-nodejs package now requires node version >= 12, this version also added to CI matrix

DMickens commented 2 years ago

I will take a look at this once I can verify we are following the correct Vertica process for accepting external PR's. This change you've proposed is in fact something we have planned for the future. For the time being, with the engine set to >=14.0 without also setting the strict flag, you should still be able to install the package via npm. You should get a warning, but should not get an error causing a failure

CLAassistant commented 2 years ago

All committers have signed the CLA.

DMickens commented 2 years ago

Merging as is. Driver works with node v12 and now will routinely be tested against v12 and v14. If we want to support earlier versions, at minimal I know we will need to work around not using Buffer.readBigUInt64BE. Future changes will be to routinely test up to current v17

korowa commented 2 years ago

Thank you, @DMickens !