search

verto-health / ngx-turnstile

Cloudflare Turnstile for Angular
https://ngx-turnstile.pages.dev/
MIT License
61 stars 12 forks source link

not working on angular 17 #21

Closed zakir1929 closed 9 months ago

zakir1929 commented 10 months ago

not working on angular 17

me-marcel commented 10 months ago

Would love to see the library being Angular 17 compatible as well. There seems to be a branch (see: https://github.com/verto-health/ngx-turnstile/tree/upgrade-angular-to-17) and PR (https://github.com/verto-health/ngx-turnstile/pull/20) but no release for this yet. Is there maybe an ETA when the update will be published?

// EDIT: I did in fact migrate the respective ngx-turnstile component to a custom library within an nx workspace now since, after careful concideration, it seems that the component itself isn't too complicated and well to maintain anyways. This eliminates the external dependency all together in my case; However, it'd still be nice to see the library being updated sooner or later.

zakir1929 commented 10 months ago

@me-marcel can you show me the way how you did it? if possible a git repo of that ?

me-marcel commented 9 months ago

@zakir1929 I'm afraid that I cannot share the entire project. However, I prepared a repository that contains the contents of the turnstile library.

https://github.com/me-marcel/nx-turnstile

Please keep in mind that you will need an NX monorepo with an Angular application for this library to work since it has dependencies on @angular/* packages.

willfarias commented 9 months ago

When it will be available? I think the only thing missing on #20 is the review, right?

me-marcel commented 9 months ago

When it will be available? I think the only thing missing on #20 is the review, right?

Seems like it. Linting is failing as well but that shouldn't be that big of a deal. I would love to do the review. Sadly, I can't.

willfarias commented 9 months ago

@cherylchen2 @AleksanderBodurri Could you help us?

natereprogle commented 9 months ago

FYI that PR was merged and a release was cut just now, Mend Renovate just notified me for a repo I have. This should be closed

AleksanderBodurri commented 9 months ago

Closed by https://github.com/verto-health/ngx-turnstile/pull/20. Thanks for the patience everyone 🙏 Let me know if there's any issues

rbalet commented 8 months ago

Hey @AleksanderBodurri , may you have forgotten to push a new version over on npm? '^^