search

vervallsweg / cast-web-api

Quick and dirty web API for Google Cast enabled devices.
GNU General Public License v3.0
141 stars 74 forks source link

Crash on concurrent playMedia calls #93

Open codahq opened 5 years ago

codahq commented 5 years ago

image

If multiple requests come in quickly this crash occurs.

codahq commented 5 years ago

This happens a lot at my house from scenarios like this: ST tells cast-web-api to TTS announce that the dryer or washing machine is finished but at the same time somebody opens the door which plays a tone. Another scenario is that the washing machine and dryer finish at nearly the same time (this almost always happens because they run about the same amount of time).

vervallsweg commented 5 years ago

Alright I see what use case causes this, thanks for elaborating!

Have you maybe tried enabling the assistant integration? This seems like a way better approach to notifications. Go to /assistant/setup and follow the guide. After that you can set your cast-web-api device in ST to your speak() device, not your speaker group.

Did this issue not occur in v1.0.0? Fixing the issue itself will be pretty hard since it's not inside my application but in a library I use.

vervallsweg commented 5 years ago

I could reproduce this behavior. Still wondering if this occurred in v.1.0.0 already.

Fixing it won't be easy, so I scheduled it for next release. For the time being use Google Assistant.