search

ververica / flink-sql-gateway

Apache License 2.0
490 stars 187 forks source link

Supported CREATE CATALOG #34

Closed fpompermaier closed 4 years ago

fpompermaier commented 4 years ago

Added support for create catalog

fpompermaier commented 4 years ago

Need to add some Postgres test before merging it

fpompermaier commented 4 years ago

Closes #33

fpompermaier commented 4 years ago

Ok, I address your comments. However I'd like to find a way to test a Postgres database because I found some problems (like the fact that SELECT * FROM mypg.postgres.public.link works while "DESCRIBE mypg.postgres.public.link does not). Also backtiks seems to be too important IMHO (the parser should be more flexible)

godfreyhe commented 4 years ago

thanks for the update @fpompermaier , LGTM, I will merge this.

Regarding to the problems you mentioned, you can open another pr.

godfreyhe commented 4 years ago

merged

fpompermaier commented 4 years ago

Maybe we should update the Readme file

godfreyhe commented 4 years ago

Thanks for reminding. I updated the readme file