search

very-good-science / data-hazards

Data Hazards is a project to find a shared vocabulary for talking about worst-case scenarios of data science - and to use that vocabulary to help people understand and avoid Data Hazards.
https://datahazards.com
Other
34 stars 17 forks source link

Hazard labels unreadable with dark mode and unable to switch to light mode #135

Open jezcope opened 2 years ago

jezcope commented 2 years ago

For some reason all Sphinx sites default to dark mode for me[^1] and because of this setting in conf.py the button in the navigation bar that I can use to switch back to light mode isn't there. The site is mostly fine in dark mode but the hazard labels themselves, with grey text on a yellow background, are almost unreadable:

image

I assume this problem was already known and that's why the dark/light toggle has been disabled, so I wanted to let you know that doing that doesn't stop dark mode from being active under some circumstances but it does prevent users from switching back to light mode if they do find themselves unable to read the labels. 🙂

I guess the long-term solution is to tweak the styling of the labels so that they always have good contrast, but somehow forcing light mode via Javascript might be a quick fix, or adding the toggle button back would allow users to work around it.

Anyway, this is a minor niggle with an otherwise great project, thanks for this work!

[^1]: I'm not sure why, but I think it may be taking this from the operating system now that several OS/desktop environments provide a global light/dark mode setting

jezcope commented 2 years ago

Oh, I realise this is probably a duplicate of #134

NatalieZelenka commented 2 years ago

Ah, thank you for this! That's really helpful. I'll take a look at this as soon as I can

On Mon, 4 Jul 2022, 11:29 Jez Cope, @.***> wrote:

Oh, I realise this is probably a duplicate of #134 https://github.com/very-good-science/data-hazards/issues/134

— Reply to this email directly, view it on GitHub https://github.com/very-good-science/data-hazards/issues/135#issuecomment-1173648616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGNDHE5DXYEFDSKIWVOBWLVSK4J3ANCNFSM52SR5AHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>