search

verybadsoldier / rp-easy-video

Helper tool to manage Retroarch shader and overlay configuration
2 stars 0 forks source link

a few considerations after a quick reading at the code #1

Open meleu opened 7 years ago

meleu commented 7 years ago

  1. If this is specific to RetroPie, you can use the already installed inifuncs.sh at /opt/retropie/lib/inifuncs.sh.

  2. It seems that this line of code will overwrite the system-specific retroarch.cfg. If the user has a customized file, it'll be lost.

I'm thinking to write a similar tool just for overlays (not for shaders) to use in https://github.com/meleu/MAME-ROW-overlays/ and I think I'll get some inspiration here... :-)

verybadsoldier commented 7 years ago

Thanks for your comments, always appreciated! :)

  1. The inifuncs.sh is not exactly the same as the one in RetroPie. I added that function "iniGetTagsAll" which extracts all the used tag names. I could try to push that function upstream though so that I could use it from RetroPie.

  2. Yes, thats true and was intended (at the moment). I don't know if anyone but me would use this anyway. If yes, then I could refine things to make it safer.

I don't know exactly what you are planning but if you see a chance to either integrate this functionality into your tool or the other way round then it would be great :)