verygoodgraphics / vgg_runtime

The official implementation of VGG Specs with cross-platform vector graphics and user interfaces.
https://verygoodgraphics.com
Other
57 stars 4 forks source link

Bugfix #319

Closed yslib closed 6 months ago

yslib commented 6 months ago

Description

template compatability for msvc nodeByID fixup

harry75369 commented 6 months ago

This PR contains two separate intentions:

  1. be compatible for msvc with addition of typename keyword
  2. fix the logical bug because findChildRecursive won't check the name of the node itself

The changing from std::string to string_view is not necessary for the problems this PR is going to solve. And the global function smells bad.