search

verygoodsecurity / vgs-collect-js

VGS Collect.js script loading module
https://www.verygoodsecurity.com/
7 stars 17 forks source link

its not working in IE 11 #25

Closed sarangpahurkar closed 3 years ago

sarangpahurkar commented 3 years ago

Expected Behavior

Credit card field should render on UI.

Current Behavior

In IE 11, all fields from VGS iframe is not getting rendered and getting error Unhandled promise rejection TypeError: Object doesn't support property or method 'append' Unhandled promise rejection TypeError: Object doesn't support property or method 'init'

Possible Solution

Not sure if its issue from vgs or its from vgs-collect-js

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

AnnaKudriasheva commented 3 years ago

@sarangpahurkar thank you for letting us know about this issue! We'll investigate and fix it asap. I'll let you know once it's done.

AnnaKudriasheva commented 3 years ago

@sarangpahurkar we've released a new version with the fix - 0.5.0. Could you please try it out and let us know if the issue is gone. Thank you!

sarangpahurkar commented 3 years ago

Sure. Thank you

On Tue, Sep 14, 2021 at 10:26 AM Anna @.***> wrote:

@sarangpahurkar https://github.com/sarangpahurkar we've released a new version with the fix - 0.5.0. Could you please try it out and let us know if the issue is gone. Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/verygoodsecurity/vgs-collect-js/issues/25#issuecomment-919361467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESUF4H76NT3AXL54JTWTVTUB6AU3ANCNFSM5DDAGP5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Thanks & Regards Sarang S. Pahurkar

sarangpahurkar commented 3 years ago

Hi @AnnaKudriasheva
Fix is working fine for one of our application but for other application I can still see error in console Unhandled promise rejection TypeError: Object doesn't support property or method 'startsWith'

content from package-lock.json where its not working "@vgs/collect-js": { "version": "0.5.0", "resolved": "https://registry.npmjs.org/@vgs/collect-js/-/collect-js-0.5.0.tgz", "integrity": "sha512-f1ZYqz32Vw147rNJ8dM9ds07OQh9cgw5GgMg6MdYyZd6v3J8IwhJPq+joPaoebcsIWvm02HLWQXm7VMmE7BCAg==", "requires": { "@types/promise-polyfill": "^6.0.4", "@types/setasap": "^2.0.0", "@types/uuid": "^8.3.0", "axios": "^0.21.1", "promise-polyfill": "8.2.0", "setasap": "^2.0.1", "uuid": "^8.3.2" }, "dependencies": { "axios": { "version": "0.21.4", "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz", "integrity": "sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==", "requires": { "follow-redirects": "^1.14.0" } }, "follow-redirects": { "version": "1.14.4", "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.14.4.tgz", "integrity": "sha512-zwGkiSXC1MUJG/qmeIFH2HBJx9u0V46QGUe3YR1fXG8bXQxq7fLj0RjLZQ5nubr9qNJUZrH+xUcwXEoXNpfS+g==" }, "uuid": { "version": "8.3.2", "resolved": "https://registry.npmjs.org/uuid/-/uuid-8.3.2.tgz", "integrity": "sha512-+NYs2QeMWy+GWFOEm9xnn6HCDp0l7QBD7ml8zLUmJ+93Q5NF0NocErnwkTkXVFNiX3/fpC6afS8Dhb/gz7R7eg==" } } },

content from package-lock json where its working

"@vgs/collect-js": { "version": "0.5.0", "resolved": "https://registry.npmjs.org/@vgs/collect-js/-/collect-js-0.5.0.tgz", "integrity": "sha512-f1ZYqz32Vw147rNJ8dM9ds07OQh9cgw5GgMg6MdYyZd6v3J8IwhJPq+joPaoebcsIWvm02HLWQXm7VMmE7BCAg==", "requires": { "@types/promise-polyfill": "6.0.4", "@types/setasap": "2.0.0", "@types/uuid": "8.3.1", "axios": "0.21.4", "promise-polyfill": "8.2.0", "setasap": "2.0.1", "uuid": "8.3.2" }, "dependencies": { "axios": { "version": "0.21.4", "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz", "integrity": "sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==", "requires": { "follow-redirects": "1.14.4" } }, "follow-redirects": { "version": "1.14.4", "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.14.4.tgz", "integrity": "sha512-zwGkiSXC1MUJG/qmeIFH2HBJx9u0V46QGUe3YR1fXG8bXQxq7fLj0RjLZQ5nubr9qNJUZrH+xUcwXEoXNpfS+g==" }, "uuid": { "version": "8.3.2", "resolved": "https://registry.npmjs.org/uuid/-/uuid-8.3.2.tgz", "integrity": "sha512-+NYs2QeMWy+GWFOEm9xnn6HCDp0l7QBD7ml8zLUmJ+93Q5NF0NocErnwkTkXVFNiX3/fpC6afS8Dhb/gz7R7eg==" } } },

sarangpahurkar commented 3 years ago

Additional details: App where its not working using node version node-v12.14.1 App where its working using node version node-v8.11.1 not sure if that's causing issue or not but just wanted to share details.

AnnaKudriasheva commented 3 years ago

@sarangpahurkar Sorry for the inconvenience. We've released a new 0.6.0 version with core-js polyfills. Could you please check if the issue is gone in a new version?

sarangpahurkar commented 3 years ago

Fix is working. Thank you