search

veryl-lang / std

Standard Library of Veryl Hardware Description Language
Apache License 2.0
1 stars 1 forks source link

Naming of `binary_encoder` and `binary_decoder` #15

Closed dalance closed 1 month ago

dalance commented 1 month ago

The naming binary_encoder and binary_decoder may be bit confusable. According to the description, unary_encoder and unary_decoder may be more suitable?

dalance commented 1 month ago

I'll change this module to private temporary. #14 After fixed the naming, I'll change to public.

nblei commented 1 month ago

The English term for hardware which converts between binary and unary representations is, in fact, binary encoder (unary -> binary) and binary decoder (binary -> unary). See Binary Encoder and Binary Decoder.

By duality, I think we would have binary_encoder = unary_decoder and binary_decoder = unary_encoder if you would like aliases for these modules.

dalance commented 1 month ago

Thanks! I didn't know the term, but it seems to be appropriate. I'll revert to public as it is.