search

verylargebox / VLBCameraView

A UIVIew that shows a live feed of the camera, can be used to take a picture, preview the picture and return a UIImage of that preview.
Other
28 stars 16 forks source link

Missing pch and xib when used as CocoaPod #1

Closed brindy closed 10 years ago

brindy commented 10 years ago

After adding VLBCameraView as a dependency I got a couple of problems:

1) DDLogError caused a compilation because of missing constant 2) Error while trying to load VLBCameraView.xib, since it did not exist

Looking at the VLBCameraView repo I can see that your pch file contains the missing constant and I can also see the xib. However, I have neither of them in the pod that was downloaded.

Looking at the Podspec for VLBCameraView it looks right, but I can see some extra tabs on a couple of the lines, especially compared to something like https://github.com/CocoaPods/Specs/blob/master/ITWLoadingPanel/1.0.1/ITWLoadingPanel.podspec

There are extra tabs on line 13 and 14 (though there are also extra tabs on line 16 and 17, but the dependencies seem to have been pulled down just fine). Could that be the problem (seems unlikely)? I would push a fix, but it seems to me that you'd have to test it yourself and also tag a new version of your code.

brindy commented 10 years ago

I just created my own private repo using a fork of VLBCameraView, removed the extra tabs from the lines mentioned above and the pch and xib are now included properly. You can see it here: https://github.com/brindy/VLBCameraView/blob/master/VLBCameraView.podspec

Not going to make a pull request as it references my repo. All you need to do is remove the extra tabs, increment the version and re-release the pod.

qnoid commented 10 years ago

Thanks @brindy for the detailed report and fix! A quick and lazy guess is that something changed in Cocoapods between now and VLBCameraViewApp release.

qnoid commented 10 years ago

Have issued a pull request to Cocoapods on a 2.0 version only because the typo effectively breaks backwards compatibility.

Didn't test the updated podspec with VLBCameraViewApp to be brutally honest. Hope haven't messed it up.