Update for Elixir v1.6 - Githubissues

verypossible / elixir-starter-kit

2 stars 1 forks source link

Update for Elixir v1.6 #50

Closed bryanenders closed 6 years ago

bryanenders commented 6 years ago

Why

Elixir v1.6 had major implications for the style guide
The code was slightly outdated

How

Set updated Elixir and Erlang versions
Update style guide
Run mix format against codebase

bryanenders commented 6 years ago

It appears to be an issue in kerl, which has been fixed for the next release. This may be blocked until the kerl patch is released and asdf updates to the patched kerl.

One option would be to remove the .tool-versions update and create an issue to update it (once asdf is updated). Thoughts?

bryanenders commented 6 years ago

We probably ought to upgrade to CircleCI 2. It has official Elixir support.

squaresurf commented 6 years ago

I agree. I started looking into that last night. @Gringill has seemed to have some success in that avenue.

bryanenders commented 6 years ago

It'd probably be a good idea to mention mix format in the style guide as well as add documentation regarding setting up CircleCI to enforce the usage of the formatter.

@squaresurf That’s a great idea. If you want to make an issue for this, that would be helpful. I went ahead and merged this PR so that the style guide wouldn't mislead.

squaresurf commented 6 years ago

@endersstocker I've created #52 :smile: