Question: Maybe untangle Borsh into it's own package?

neverything commented 2 years ago

What would this mean?

Should the Buffer become part of the Borsh package?
Would the Exceptions become part of the Borsh package?
What about the PublicKey that now is part as of this change (https://github.com/tighten/solana-php-sdk/commit/d032405c5f5ef7d91d7f245a2e0f11cea6eb3c4f#diff-bc3a24552d6e6304731de9cd989008ec466e662dfd2d77273ea76f4749755970)?
Anything I'm missing?

Would love to help out

neverything commented 2 years ago

Ping @mattstauffer, only if you have a moment good ser

mattstauffer commented 2 years ago

Whoops, I'm sorry I didn't see this originally! I would love to extract it... but I don't know how to answer your questions. I think exceptions are the easiest: we can just make custom exceptions in that package and update this package to be aware of them.

With Buffer, if we need to use buffers in our Borsh package, then this package can just consume those, so that's fine.

I think the same will have to be true about the PublicKey. Basically anything the Borsh package needs, should move there, and then this package can just get them from there, even if that seems a bit silly.

verze-app / solana-php-sdk

Question: Maybe untangle Borsh into it's own package? #20