search

veskuh / Tweetian

A feature-rich Twitter app for smartphones developed using Qt/QML
GNU General Public License v3.0
50 stars 26 forks source link

TabPageHeader redesign + small fixes #116

Closed Morpog closed 10 years ago

Morpog commented 10 years ago

Unfortunately it does not make sense to show content behind TabPageHeader, because I would need to add a margin at bottom in SlideShowView with same height as TabPageHeader, so that all content can be scrolled above the TabPageHeader. Maybe someone else can find a solution for that?

veskuh commented 10 years ago

I don't like how this looks in normal situation. It makes the tab header too prominent. I like current look of tab page header. It is there but it does not draw attention, and the focus is on the content.

This does solve the issue of content showing up behind menu when push up menu is open. I have found an alternative solution (exposing the true height from TabHeader and using it for mainView) for that problem which I'm going to use instead of this.

Tab header height I'll change to suggested one.

Morpog commented 10 years ago

Yeah, without the content behind it looks a bit out of place. Also it needs a bit getting used to. As I liked the old behavior too I'm closing this and checking out your commits. Will do a follow up with the small fixes and icons.