search

veskuh / Tweetian

A feature-rich Twitter app for smartphones developed using Qt/QML
GNU General Public License v3.0
50 stars 26 forks source link

Added option to adjust font size #127

Closed CODeRUS closed 10 years ago

veskuh commented 10 years ago

Tweet delegates do not properly resize themselves after size change. After restart all is fine. The issue is not in this pull request though. There seems to be some issues in Qt's Text.RichText handling bits. I already did nasty hack for handling width change. Perhaps same hack https://github.com/veskuh/Tweetian/commit/357ce89de6d267d6647cd7376191047233bb49f4 would force delegates properly relayout themselves after font size change

veskuh commented 10 years ago

The other option I'm considering is to just show the plain text version in tweet lists. The upside of that is that it makes performance even better.

CODeRUS commented 10 years ago

what is rich text for? linkify urls and emails?

veskuh commented 10 years ago

Yes, for formatting links. For normal links styled text and underline would be ok, but it does not look good on hashtag and email links and you cannot get rid of it in Text.StyledText.

CODeRUS commented 10 years ago

i didnt understand. what wrong with StyledText?

veskuh commented 10 years ago

With styled text you cannot remove the underline from links.

veskuh commented 10 years ago

Ok, I'm merging this now. In any case user can restart to get the first delegates to relayout properly. Thanks.