search

vesoft-inc / nebula-agent

Apache License 2.0
6 stars 8 forks source link

consider non-binary deployment use case #22

Open wey-gu opened 2 years ago

wey-gu commented 2 years ago

Now, the agent calls the service script with bash with the assumptions that the agent is running together with the service:

  1. with same hostname
  2. sharing same filesystem, home path & service was started with scripts/nebula.service stop

https://github.com/vesoft-inc/nebula-agent/blob/96646b8f19bea1d9faae99dc72990d8110532aa0/internal/clients/daemon.go#L95-L100

For 1. it's do able like a sidecar design in both docker and k8s:

https://github.com/wey-gu/nebula-up/blob/9bd28601f9cb156d77009c724f09164b02f07393/backup_restore/docker-compose.yaml#L54-L59

While for 2. it's really hard to mitigate, introducing hooks to make this work is too hacky.

We need to revisit the design to enable service stop/start w/o assuming leveraging scripts.

wey-gu commented 2 years ago

user report failure of BR in k8s:

Lichil commented 12 months ago

咨询下，在 br 支撑 k8s 环境备份有下一步计划吗？

wenhaocs commented 12 months ago

It's supported already: https://docs.nebula-graph.io/3.4.0/nebula-operator/10.backup-restore-using-operator/