search

vesoft-inc / nebula-flink-connector

Flink Connector for Nebula Graph
48 stars 30 forks source link

Do we need to support FLIP-27: Refactor Source Interface #65

Closed spike-liu closed 2 years ago

spike-liu commented 2 years ago

Split discussion from https://github.com/vesoft-inc/nebula-flink-connector/issues/38

spike-liu commented 2 years ago

https://cwiki.apache.org/confluence/display/FLINK/FLIP-27%3A+Refactor+Source+Interface

spike-liu commented 2 years ago

Here is my research:

  1. The problems mentioned below currently are not problem for nebula connector.

    image

  2. Currently only message queue framework, such as Kafka/Pulsar, implemented this new API.

    image

So far, from my point of view, there is no motivation for us to implement these new source API.

@Nicole00 what is your idea?

Nicole00 commented 2 years ago

Sorry I missed this issue, I'll research it and reply later.

Nicole00 commented 2 years ago

I agree with @spike-liu . The main motivation of flip-27 is to facilitate the expansion of data sources and lower the threshold for everyone to contribute source code. Sense we have extended the Nebula data source, it seems there's no need to refactor the interface.

And the use requirement of checkpoint is not high, so I tend to see the support of FILP-27 as a future requirement.

spike-liu commented 2 years ago

Thanks for your reply. @Nicole00

Closed.