search

vesoft-inc / nebula-flink-connector

Flink Connector for Nebula Graph
48 stars 30 forks source link

refactor table name design #75

Closed liuxiaocs7 closed 2 years ago

liuxiaocs7 commented 2 years ago

try to fix #70

liuxiaocs7 commented 2 years ago

In the implementation:

  1. Use the graph-space and table-name parameters to determine the specific tag/edge instead of relying on the table name in Flink SQL
  2. update some test logic
codecov-commenter commented 2 years ago

Codecov Report

Base: 61.54% // Head: 61.69% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (88b6b79) compared to base (5243fb7). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #75 +/- ## ============================================ + Coverage 61.54% 61.69% +0.15% Complexity 291 291 ============================================ Files 52 52 Lines 1784 1791 +7 Branches 166 166 ============================================ + Hits 1098 1105 +7 Misses 596 596 Partials 90 90 ``` | [Impacted Files](https://codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc) | Coverage Δ | | |---|---|---| | [...nector/nebula/table/NebulaDynamicTableFactory.java](https://codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/75/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-Y29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnLmFwYWNoZS5mbGluay9jb25uZWN0b3IvbmVidWxhL3RhYmxlL05lYnVsYUR5bmFtaWNUYWJsZUZhY3RvcnkuamF2YQ==) | `97.03% <100.00%> (+0.16%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.