vesoft-inc / nebula-flink-connector

Flink Connector for Nebula Graph
48 stars 30 forks source link

Reduce code duplication in integration tests #82

Closed linhr closed 1 year ago

linhr commented 1 year ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number: N/A

Description:

The integration tests contain duplicated code for initializing session, defining schema, and executing nGQL statements, etc. We can do some refactoring to extract shared logic for all tests.

How do you solve it?

I refactored a few test classes to make them inherit from NebulaITTestBase which contains shared logic for test setup. There is no change to the functionality.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

N/A