vesoft-inc / nebula-flink-connector

Flink Connector for Nebula Graph
49 stars 30 forks source link

Fix "SSL sign type" typo #86

Closed linhr closed 1 year ago

linhr commented 1 year ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number

N/A

Description

SSLSignType was incorrectly spelled as SSLSighType.

How do you solve it?

The typo is fixed.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

N/A

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.11 :warning:

Comparison is base (6b3cad3) 65.12% compared to head (604f721) 65.01%.

:exclamation: Current head 604f721 differs from pull request most recent head be538b8. Consider uploading reports for the commit be538b8 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ============================================ - Coverage 65.12% 65.01% -0.11% + Complexity 309 308 -1 ============================================ Files 53 53 Lines 1878 1878 Branches 167 167 ============================================ - Hits 1223 1221 -2 - Misses 570 571 +1 - Partials 85 86 +1 ``` | [Impacted Files](https://app.codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc) | Coverage Δ | | |---|---|---| | [...bula/connection/NebulaGraphConnectionProvider.java](https://app.codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-Y29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnLmFwYWNoZS5mbGluay9jb25uZWN0b3IvbmVidWxhL2Nvbm5lY3Rpb24vTmVidWxhR3JhcGhDb25uZWN0aW9uUHJvdmlkZXIuamF2YQ==) | `76.66% <0.00%> (ø)` | | | [...ebula/connection/NebulaMetaConnectionProvider.java](https://app.codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-Y29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnLmFwYWNoZS5mbGluay9jb25uZWN0b3IvbmVidWxhL2Nvbm5lY3Rpb24vTmVidWxhTWV0YUNvbm5lY3Rpb25Qcm92aWRlci5qYXZh) | `59.25% <0.00%> (ø)` | | | [...la/connection/NebulaStorageConnectionProvider.java](https://app.codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-Y29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnLmFwYWNoZS5mbGluay9jb25uZWN0b3IvbmVidWxhL2Nvbm5lY3Rpb24vTmVidWxhU3RvcmFnZUNvbm5lY3Rpb25Qcm92aWRlci5qYXZh) | `32.14% <0.00%> (ø)` | | | [...nnector/nebula/connection/NebulaClientOptions.java](https://app.codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-Y29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnLmFwYWNoZS5mbGluay9jb25uZWN0b3IvbmVidWxhL2Nvbm5lY3Rpb24vTmVidWxhQ2xpZW50T3B0aW9ucy5qYXZh) | `91.25% <83.33%> (ø)` | | | [...ache.flink/connector/nebula/utils/SSLSignType.java](https://app.codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-Y29ubmVjdG9yL3NyYy9tYWluL2phdmEvb3JnLmFwYWNoZS5mbGluay9jb25uZWN0b3IvbmVidWxhL3V0aWxzL1NTTFNpZ25UeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vesoft-inc/nebula-flink-connector/pull/86/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.