vesoft-inc / nebula-go

Nebula client in Golang
Apache License 2.0
134 stars 70 forks source link

fix #272 #273

Closed HarrisChu closed 1 year ago

HarrisChu commented 1 year ago

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-go/issues/272

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.81 :tada:

Comparison is base (3ed8926) 61.30% compared to head (dbf6afd) 62.12%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #273 +/- ## ========================================== + Coverage 61.30% 62.12% +0.81% ========================================== Files 9 9 Lines 2308 2305 -3 ========================================== + Hits 1415 1432 +17 + Misses 748 734 -14 + Partials 145 139 -6 ``` | [Impacted Files](https://codecov.io/gh/vesoft-inc/nebula-go/pull/273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc) | Coverage Δ | | |---|---|---| | [connection\_pool.go](https://codecov.io/gh/vesoft-inc/nebula-go/pull/273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-Y29ubmVjdGlvbl9wb29sLmdv) | `81.46% <100.00%> (+2.72%)` | :arrow_up: | | [session.go](https://codecov.io/gh/vesoft-inc/nebula-go/pull/273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc#diff-c2Vzc2lvbi5nbw==) | `50.80% <100.00%> (+3.10%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/vesoft-inc/nebula-go/pull/273/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vesoft-inc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.