search

vesoft-inc / nebula-go

Nebula client in Golang
Apache License 2.0
134 stars 70 forks source link

support to config the version white list #300

Closed Nicole00 closed 8 months ago

Nicole00 commented 8 months ago

close https://github.com/vesoft-inc/nebula-go/issues/299

codecov-commenter commented 8 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (fde0af0) 63.30% compared to head (2a5a573) 63.41%.

Files Patch % Lines
configs.go 20.00% 4 Missing :warning:
connection_pool.go 75.00% 0 Missing and 2 partials :warning:
connection.go 85.71% 1 Missing :warning:
session_pool.go 50.00% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #300 +/- ## ========================================== + Coverage 63.30% 63.41% +0.11% ========================================== Files 8 8 Lines 2382 2392 +10 ========================================== + Hits 1508 1517 +9 - Misses 748 750 +2 + Partials 126 125 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarrisChu commented 8 months ago

why need user provide the version? user changes the client_white_list in graphd?

Nicole00 commented 8 months ago

why need user provide the version? user changes the client_white_list in graphd?

Yeah, this version config is optional. the default value is 3.0.0, and if you set value for version, need to make sure the value is in client_white_list in nebula-graph.conf.