search

vesoft-inc / nebula-go

Nebula client in Golang
Apache License 2.0
134 stars 70 forks source link

hotfix: fix the field index conflict inside the method Scan of ResultSet #305

Closed haoxins closed 9 months ago

haoxins commented 9 months ago

This is hotfix because there is a variable overriding of the i :)

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

haoxins commented 9 months ago

cc @Nicole00 @wey-gu tested in my service and will add more tests in the future

codecov-commenter commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3fe0bb1) 63.37% compared to head (c6c2d6b) 63.37%.

Files Patch % Lines
result_set.go 87.50% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #305 +/- ## ======================================= Coverage 63.37% 63.37% ======================================= Files 9 9 Lines 2452 2452 ======================================= Hits 1554 1554 Misses 768 768 Partials 130 130 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.