As in connection_pool.go, ConnectionPool deactivates the current connection by putting it to idle queue if authentication failed (i.e. conn.authenticate returns an non-nil error). However, if authentication returns an nil error but with an unsuccessful ErrorCode, the connection won't be deactivated. Therefore, consecutive unsuccessful responses of authentication could eventually use up the connection pool, causing no new connections is able to be created.
How do you solve it?
I treat both authentication failure scenarios with the same handling, that the connection is put back to idle queue if failed.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#334
Description:
As in connection_pool.go, ConnectionPool deactivates the current connection by putting it to idle queue if authentication failed (i.e. conn.authenticate returns an non-nil error). However, if authentication returns an nil error but with an unsuccessful ErrorCode, the connection won't be deactivated. Therefore, consecutive unsuccessful responses of authentication could eventually use up the connection pool, causing no new connections is able to be created.
How do you solve it?
I treat both authentication failure scenarios with the same handling, that the connection is put back to idle queue if failed.
Special notes for your reviewer, ex. impact of this fix, design document, etc: